Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support credential flags #46

Closed
Temikus opened this issue Oct 28, 2020 · 1 comment
Closed

Support credential flags #46

Temikus opened this issue Oct 28, 2020 · 1 comment
Assignees

Comments

@Temikus
Copy link
Collaborator

Temikus commented Oct 28, 2020

Currently we don't support passing credentials to ts-bridge directly. It's all done through google-cloud-go library support, so classic application default credentials.

Design:

  • App would support additional 2 methods of auth:
    • `--google-json-key" argument and associated env variable allowing to pass in a JSON account key to the app
    • `--google-json-key-string" argument and associated env variable allowing to pass the same account key file as a string
  • If set, those flags must override other methods of selecting auth (library already does it so it should be enough to just be careful when piping the options through)

This should require just piping through the options from the lib, described here: https://github.com/googleapis/google-cloud-go#authorization

@Temikus
Copy link
Collaborator Author

Temikus commented Dec 9, 2020

Decided against it.

@Temikus Temikus closed this as completed Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants