Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tasks to log data to TurbiniaTaskResult #328

Open
aarontp opened this issue Dec 13, 2018 · 2 comments
Open

Update tasks to log data to TurbiniaTaskResult #328

aarontp opened this issue Dec 13, 2018 · 2 comments

Comments

@aarontp
Copy link
Member

aarontp commented Dec 13, 2018

Right now a lot of the logging from the tasks does not get propagated back to the user, so we should make sure that all of the tasks are adding logs and errors to the results so that at minimum the data gets put into the worker-log.txt. Ideally we would store this info in datastore so that the clients could query it later (this part is in #115).

@aarontp
Copy link
Member Author

aarontp commented Dec 16, 2018

Another way we could handle this is to create a custom log handler that saves the logs when logged via the normal logging mechanism and then attaches the logs logged for the given task to the result.

@aarontp
Copy link
Member Author

aarontp commented Aug 23, 2019

This is already mostly done as the Tasks should be using TurbiniaTask.log(). This does python logging as well as save to TurbiniaResult so that they are later written as worker-log.txt. The last thing that needs to be done is to verify that all of the normal python logging calls are removed in favor of task.log(), so that we are not missing any logs in the saved worker log.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant