Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor TurbiniaClient.get_task_data() into state_manager #358

Open
aarontp opened this issue Feb 20, 2019 · 1 comment
Open

Refactor TurbiniaClient.get_task_data() into state_manager #358

aarontp opened this issue Feb 20, 2019 · 1 comment

Comments

@aarontp
Copy link
Member

aarontp commented Feb 20, 2019

Right now the bulk of the get_task_data() function for the GCP implementation exists within client.py, and the same function for Redis is in the RedisStateManager object. The two implementations have also not been kept in parity (the later doesn't currently support looking up tasks by user). We should move the get_task_data() from client.py and add it to the BaseStateManager to make sure they are using the same interface and are both kept up to date.

@ericzinnikas FYI: See above about the get_task_data() not currently being in parity between the two implementations. If I don't get to this refactoring soon, we can probably just add a quick fix to support looking up tasks by user to start with in the Redis implementation.

@aarontp
Copy link
Member Author

aarontp commented Feb 21, 2019

FYI, I found other problems with the user attribute, so I filed #359 (which also covers supporting this attribute in the Redis setup).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant