You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now the bulk of the get_task_data() function for the GCP implementation exists within client.py, and the same function for Redis is in the RedisStateManager object. The two implementations have also not been kept in parity (the later doesn't currently support looking up tasks by user). We should move the get_task_data() from client.py and add it to the BaseStateManager to make sure they are using the same interface and are both kept up to date.
@ericzinnikas FYI: See above about the get_task_data() not currently being in parity between the two implementations. If I don't get to this refactoring soon, we can probably just add a quick fix to support looking up tasks by user to start with in the Redis implementation.
The text was updated successfully, but these errors were encountered:
Right now the bulk of the
get_task_data()
function for the GCP implementation exists withinclient.py
, and the same function for Redis is in theRedisStateManager
object. The two implementations have also not been kept in parity (the later doesn't currently support looking up tasks by user). We should move theget_task_data()
fromclient.py
and add it to theBaseStateManager
to make sure they are using the same interface and are both kept up to date.@ericzinnikas FYI: See above about the get_task_data() not currently being in parity between the two implementations. If I don't get to this refactoring soon, we can probably just add a quick fix to support looking up tasks by user to start with in the Redis implementation.
The text was updated successfully, but these errors were encountered: