Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Turbinia instance as datastore namespace #88

Closed
aarontp opened this issue Oct 21, 2017 · 3 comments
Closed

Add Turbinia instance as datastore namespace #88

aarontp opened this issue Oct 21, 2017 · 3 comments
Labels
enhancement Prio4 Probably won't get to this, but it's a nice to have

Comments

@aarontp
Copy link
Member

aarontp commented Oct 21, 2017

Right now when we save data into Datastore we don't have any way to distinguish which Turbinia instance is saving the entities, which means that we can't have more than one Turbinia instance per cloud project without mixing the task status results together. We should add a new 'instance' (or something similar) as part of the entity key to help disambiguate. We could potentially use the config.PSQ_TOPIC variable here as this should already be unique.

@aarontp aarontp added this to To Do in turbiniactl status via automation Nov 3, 2017
@aarontp
Copy link
Member Author

aarontp commented Nov 3, 2017

Also need to make sure that the TurbiniaRequestId is there.

@aarontp aarontp moved this from To Do to Done in turbiniactl status Nov 16, 2017
@aarontp
Copy link
Member Author

aarontp commented Nov 16, 2017

Instance is now a datastore TurbiniaTask entity attribute, but I'm keeping this open to add this as a namespace, which is a Datastore concept for multi-tenancy, rather than as an attribute.

@aarontp aarontp changed the title Add Turbinia instance attribute to datastore key Add Turbinia instance as datastore namespace Feb 19, 2019
@aarontp
Copy link
Member Author

aarontp commented Sep 27, 2019

This is quite a low priority given that everything works just fine with multiple instances in the same project. We could still do this to be more Datastore idiomatic, but it's really not needed. Closing this out.

@aarontp aarontp closed this as completed Sep 27, 2019
@aarontp aarontp added Prio4 Probably won't get to this, but it's a nice to have and removed Prio2 labels Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Prio4 Probably won't get to this, but it's a nice to have
Projects
No open projects
Development

No branches or pull requests

1 participant