Implement json decoding for Any message. #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haberman
requested changes
Nov 7, 2018
upb/json/parser.rl
Outdated
| return false; | ||
| } | ||
|
|
||
| json_parser_any_frame_set_packed(p, p->top->any_frame, packed); |
There was a problem hiding this comment.
Can we use a name other than "packed"? I thought this was somehow related to packed repeated fields. Maybe json_parser_any_frame_set_type()? And maybe call the variable here any_type?
There was a problem hiding this comment.
changed to payload_type.
upb/json/parser.rl
Outdated
| upb_json_parser* parser; | ||
| upb_sink sink; | ||
|
|
||
| /* Mark the range of unpacked values in json input before type url. */ |
There was a problem hiding this comment.
Maybe uninterpreted instead of unpacked?
| @@ -191,6 +191,9 @@ endif | |||
| upb_json_SRCS = \ | |||
| upb/json/parser.c \ | |||
| upb/json/printer.c \ | |||
| upb/pb/encoder.c \ | |||
There was a problem hiding this comment.
We shouldn't put these sources in more than one library. Instead add dependencies on libupb.pb.a to binaries that need it.
Or help me get Kokoro Bazel tests going, so we can delete the Travis tests and the Makefile completely.
There was a problem hiding this comment.
Left this. Will fix it after kokoro fix.
haberman
approved these changes
Nov 14, 2018
type url may not appear as the first value in json. As a result, other data cannot be resolved before resolving type url. To solve that, this change caches the start and end position of unparsed values and resolve them in end_any_object when type url has been resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
type url may not appear as the first value in json. As a result,
other data cannot be resolved before resolving type url. To solve that,
this change caches the start and end position of unparsed values and
resolve them in end_any_object when type url has been resolved.