Add flag to MessageDef for whether fields have presence. #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haberman
force-pushed
the
presenceflag
branch
5 times, most recently
from
497e7a7
to
ba4b6f5
Compare
|
Sounds like @tbetbetbe is on vacation, @scwhittle want to take a look? Context is: we want to support proto2/proto3 simultaneously, which means having a flag in each message indicating whether it has proto2 presence semantics or proto3. |
|
|
||
| /* Primitive field: return true unless there is a message that specifies | ||
| * presence should not exist. */ | ||
| if (f->msg_is_symbolic || !f->msg.def) return true; |
There was a problem hiding this comment.
would it be better to assert that the msg is not symbolic?
Returning true unconditionally seems incorrect
and a reminder, when would the message def be null?
There was a problem hiding this comment.
It would only be NULL before the field has been added to a message.
To me this is just implementing a sane default: presence defaults to true, but is false in cases where it is known to be false.
|
PTAL. |
haberman
added a commit
that referenced
this pull request
Oct 21, 2015
Add flag to MessageDef for whether fields have presence.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a step towards proto2 (descriptor.proto) support.
Review to @tbetbetbe.