Changed JSON parser/printer to correctly camelCase names. #46
Conversation
|
Review to @scwhittle. |
| @@ -721,6 +722,35 @@ const char *upb_fielddef_name(const upb_fielddef *f) { | |||
| return upb_def_fullname(upb_fielddef_upcast(f)); | |||
| } | |||
|
|
|||
| bool upb_fielddef_getjsonname(const upb_fielddef *f, char *buf) { | |||
There was a problem hiding this comment.
why is this a method on fielddef instead of a different method taking any const char* name and camel casing?
If it has to be a method on fielddef, perhaps separate the transformation to a separate helper method that might be useful elsewhere for json
There was a problem hiding this comment.
seems safer to pass in the size of buf and perform checks on that
There was a problem hiding this comment.
Camel casing the regular name is the default for the JSON name, but it can also explicitly be set to something else. See: https://github.com/google/protobuf/blob/master/src/google/protobuf/descriptor.proto#L193
Separating out as a utility function could possibly be useful, but I'd rather late-bind on that.
There was a problem hiding this comment.
Done on your second suggestion.
|
Addressed comments, PTAL. |
|
Added asserts, PTAL. |
|
LGTM |
Changed JSON parser/printer to correctly camelCase names.
This required adding support for json_name (and its camelCase transformation from the regular name) to upb_fielddef.
For now we are not adding a json_name -> fielddef* map to upb_msgdef. In many/most cases this will never be used. Instead we add the map to the JSON parser's data it creates up-front.