Handle oneof fields in DefBuilder #50
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upb/bindings/googlepb/bridge.cc
Outdated
| @@ -94,9 +94,23 @@ const MessageDef* DefBuilder::GetMaybeUnfrozenMessageDef( | |||
| fields.push_back(d->field(i)); | |||
| } | |||
|
|
|||
| // Oneof fields | |||
| for (int i = 0, maxi = d->oneof_decl_count(); i < maxi; ++i) { | |||
There was a problem hiding this comment.
Wrap in #ifdef GOOGLE_PROTOBUF_HAS_ONEOF so it can compile against protobuf < 2.6.0 (which introduced oneof support).
|
Sorry about that. Added #ifdefs (not actually tested with an old protobuf release, though). |
|
Changes Unknown when pulling 9a0cee2 on mbarbon:bridge-oneof into ** on google:master**. |
|
Thanks for the contribution -- sorry I didn't merge it at the time. Since then I have removed this functionality: now to convert between protobuf descriptors and upb descriptors you just serialize and parse. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.