Added migration flag for users using old JSON format. #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review to @scwhittle. |
| len = upb_fielddef_getjsonname(f, ret->ptr, ret->len); | ||
| UPB_ASSERT_VAR(len, len == ret->len); | ||
| ret->len--; /* NULL */ | ||
| if (getenv("UPB_JSON_WRITE_LEGACY_FIELD_NAMES")) { |
There was a problem hiding this comment.
Is this a performance concern? You could cache somewhere instead of looking up the env variable repeatedly
There was a problem hiding this comment.
This code runs at handler creation time, not at print time.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended for Ruby users who may currently be using JSON format. The Ruby JSON format was written before we realized that proto3 JSON would be camelCasing field names, so it always used original field names. The most recent upb code fixes this problem, but this could cause problems for any Ruby users who are currently using JSON.
These Ruby users should migrate, but it may be difficult to do all at once. So we are providing these flags for now to make the migration easier.
In the longer term, if Ruby users need compatibility with existing payloads, they should use the
json_nameoption in their.protofiles to specify the old names. Unfortunately proto3 Ruby doesn't supportjson_nameyet. We will add support for it before we remove these flags.