Vector*.random constuctor

[bergwerf]

See #170
The code generation tool has added some code to the 64bit float library that did not exists before (someone forgot to run it?). The formatting of some parts is also altered since I ran dartfmt.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please let us know the company's name.

[bergwerf]

I have signed the Google CLA now.

[googlebot]

CLAs look good, thanks!

[johnmccutchan]

What is with the unnecessary formatting changes?

[bergwerf]

I used dartfmt, and the previous commits apparently didn't. dartfmt adds some kind of line breaks after comments. I would say it's generally a good idea to stick to the Dart style conventions.

[bergwerf]

If you want I can create a branch that is not formatted.

[johnmccutchan]

Hi,

Sorry I forgot about this pull request. Can you refresh it and I'll take another look?

Thanks,
John

[bergwerf]

Do you want me to take out the formatting? As I said I use a tool that runs dartfmt on my entire dart directory, and some parts of this project were manually formatted. But I can take them out.

[johnmccutchan]

Keep the formatting but keep it as a separate commit.

[johnmccutchan]

@hermanbergwerf You need to update the CL so that I can merge it.

[bergwerf]

I know, I'm very busy these weeks, sorry. I'll look into it ASAP.

Op do 28 jul. 2016 om 09:44 schreef John McCutchan <notifications@github.com

:

@hermanbergwerf https://github.com/hermanbergwerf You need to update
the CL so that I can merge it.

—
You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#172 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEQJ1Yf6mmvzWnCvhk39auUY-hgKGaJqks5qaM5XgaJpZM4JBDnb
.

[bergwerf]

I figured it would be easier to overwrite my fork. I have not used dartfmt so there are no formatting changes. I think those should be handled separately.

[johnmccutchan]

Thanks!