Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quaternion unary - takes the conjugate instead of memberwise negation #276

Closed
AsturaPhoenix opened this issue Dec 21, 2022 · 2 comments · Fixed by #316
Closed

Quaternion unary - takes the conjugate instead of memberwise negation #276

AsturaPhoenix opened this issue Dec 21, 2022 · 2 comments · Fixed by #316

Comments

@AsturaPhoenix
Copy link

AsturaPhoenix commented Dec 21, 2022 •
edited

Currently quaternion negation takes the conjugate rather than scaling by -1, which was surprising to me and doesn't seem consistent with binary operator -, which indeed subtracts memberwise.

This seems to be a regression introduced many years ago at e7bf99e#diff-f11831298dd6e7900532989a327b8f1934d513eb3e33faa366c68c1a44227c5eR377

This applies to both vector_math and vector_math_64.
@johnmccutchan
Copy link
Collaborator

Hi,

Please send a PR to fix the issue.

@johnmccutchan
Copy link
Collaborator

@AsturaPhoenix

@tlserver tlserver mentioned this issue Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix quaternion negate tlserver/vector_math.dart
2 participants
@johnmccutchan @AsturaPhoenix