Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider sealing vector_math classes #298

Open
johnmccutchan opened this issue Jun 20, 2023 · 1 comment
Open

Consider sealing vector_math classes #298

johnmccutchan opened this issue Jun 20, 2023 · 1 comment

Comments

@johnmccutchan
Copy link
Collaborator

@rakudrama @spydon Forking the conversation from the pull request.

@spydon
Copy link
Collaborator

spydon commented Jun 20, 2023

Good idea with an issue!
I understand if you would want to mark the classes as sealed, then all of us that have extended any of the classes will of course have to create a new library that fits our needs better, but such is OSS life. :)

Like I said in the PR though, if you do mark them as sealed I hope that you also bump major, since it is a breaking change and will break all previous versions of Flame (and other apps and packages), since we have depended on that vector_math follows semver (which it has done so far) and as such we use the caret syntax.

And lastly; is there anything in my PRs blocking the classes from being sealed later, if not, why could they not be merged and released first? Since I doubt that vector_math will move over to sealed classes over night.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants