Skip to content
This repository has been archived by the owner on Nov 9, 2022. It is now read-only.

Delegate to the maktaba#selector API #10

Open
malcolmr opened this issue May 28, 2020 · 2 comments
Open

Delegate to the maktaba#selector API #10

malcolmr opened this issue May 28, 2020 · 2 comments

Comments

@malcolmr
Copy link
Member

My understanding of google/vim-maktaba#208 is that we forked most of the guts of this project into Maktaba, as maktaba#selector#Create.

David's comment in google/vim-maktaba#209 finished:

Next step will be to gut the vim-selector implementation once users have had some time to update maktaba and make it delegate to maktaba for all the non-legacy implementation, and then to mark the whole vim-selector plugin deprecated.

I think we still have that to do, here.

@dbarnett
Copy link
Contributor

dbarnett commented Aug 5, 2021

Actually, the backwards compatibility precautions are probably more trouble than they're worth. We could just add a deprecation notice, make sure our own usages are updated to the maktaba#selector# version, and archive the repo.

@dbarnett
Copy link
Contributor

dbarnett commented Aug 9, 2021

Let's also leave a note in a stub README here in the archived repo if there are any compatibility tricks like including an explicit <CR> action, or checking out a particular maktaba version temporarily to avoid newer API changes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants