Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix javadoc comments #4

Closed
matgallacher opened this issue Jan 25, 2017 · 1 comment
Closed

Fix javadoc comments #4

matgallacher opened this issue Jan 25, 2017 · 1 comment

Comments

@matgallacher
Copy link

matgallacher commented Jan 25, 2017

Javadoc specs have changed and compilation fails with the following issues with java 8

C:\Repos\Volley\volley\src\main\java\com\android\volley\toolbox\BasicNetwork.java:268: error: malformed HTML * Converts Headers[] to Map. ^ C:\Repos\Volley\volley\src\main\java\com\android\volley\toolbox\BasicNetwork.java:268: error: bad use of '>' * Converts Headers[] to Map. ^ C:\Repos\Volley\volley\src\main\java\com\android\volley\VolleyLog.java:40: error: self-closing element not allowed *
^ C:\Repos\Volley\volley\src\main\java\com\android\volley\VolleyLog.java:42: error: self-closing element not allowed *
^ C:\Repos\Volley\volley\src\main\java\com\android\volley\VolleyLog.java:28: error: self-closing element not allowed *

^ C:\Repos\Volley\volley\src\main\java\com\android\volley\VolleyLog.java:29: error: self-closing element not allowed * to see Volley logs call:
^

@jpd236
Copy link
Collaborator

jpd236 commented Jan 25, 2017

It seems like Java 8 made Javadoc linting the default, though I don't believe the specs themselves have changed (in other words, we can just fix these and they will still make sense with older compilers).

Probably just need to use {@code Headers[]} and {@code Map<String, String>} in BasicNetwork and change the <br />s to <br>s and <p/>s to <p>s in VolleyLog. PR welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants