Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to use libc++ in CMake builds #52

Open
kuhar opened this issue Sep 29, 2021 · 4 comments
Open

Allow to use libc++ in CMake builds #52

kuhar opened this issue Sep 29, 2021 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@kuhar
Copy link
Contributor

kuhar commented Sep 29, 2021

The filesystem library is hardcoded as the libstdc++ one:

set(FILESYSTEM_LIB_NAME stdc++fs)
@kuhar kuhar added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Sep 29, 2021
@Forchapeatl
Copy link

Forchapeatl commented Nov 2, 2022 •
edited

Hello @kuhar , please may I take this issue ?

@kuhar
Copy link
Contributor Author

kuhar commented Nov 2, 2022 •
edited

@Forchapeatl Sure! Let me know if you have any questions.

@Forchapeatl
Copy link

Forchapeatl commented Nov 2, 2022 •
edited

Please it seems like there issue was solved 9 days ago. Is there any thing else I could help with?

vulkan-performance-layers/CMakeLists.txt

Line 25 in 1571ee5

set(FILESYSTEM_LIB_NAME stdc++fs)

@kuhar
Copy link
Contributor Author

kuhar commented Nov 2, 2022

This part of the CMake file hasn't changed in about a year. Currently, we use stdc++fs unconditionally, even when the prefered one is different (libstd++ vs. libc++).

Related discussion:

@Forchapeatl Forchapeatl mentioned this issue Nov 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

changed stdc++fs to libc++ Forchapeatl/vulkan-performance-layers
2 participants
@kuhar @Forchapeatl