New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Taxonomy Support (Tags, Categories) #489
Comments
Couldn't find design currently in Figma for this, assuming it should be in the Document panel. @o-fernandez -- adding UX Needed label, LMK if the design actually exists and I missed it, so we can add it to the description as well. cc @samitron7 |
@pbakaus @swissspidy Want your thoughts here. IIRC, our main way of getting the story into the site's various feeds and distribution will be by having users embed their story into a post they publish. Is that still the plan? If so, then the priority of this could possibly drop, since the article/post where the story is embedded could be where the right categories/tags are added. Let me know what you think. |
Yes. I think this would be more about helping publishers organize their content in the admin rather than having to do anything with distribution. |
Great, thanks for confirming @swissspidy. I think that makes sense, and definitely important to do, but lowers the urgency in my mind. Let me discuss prioritization with Sam in our upcoming 1-1. |
Sounds good. To give some more context: Right now stories already support adding tags & categories via the "All Stories" view (aka classic WordPress list table): They're also already shown in the Dashboard: Maybe that's a bit confusing for users? So this issue would only be about adding them to the Document panel in the editor. Another interesting aspect: right now the tags and categories are shared with regular posts. So if you have the tag "Awesome", it can be added to both a post and a story. However, we could also make them unique to stories, and not shared with posts. |
Open questions:
If we feel comfortable saying that we have answers for these, then we could build this now. Otherwise, do we have the option to hide these from the dashboard and "all stories" sections until we have user feedback/need to determine how we should implement this? @swissspidy @pbakaus @carlos-kelly |
I don't think so. Even in WordPress itself many users find it confusing to have both options. IMO 1 option - tags - is enough.
Sharing tags can cause issues in WP, as the counts for how often a tag is used can be wrong inn this case. Personally I'd argue for not doing this sharing.
Yes we do. Should be relatively simple to make this change. My suggestion: let's do that until we have user feedback. It's not a V1 feature anyway. |
Thanks @swissspidy - that sounds good! Moving this out of the Beta/Stable release. Filed #1884 for now. |
There was a user request for this at #3107 |
This one is quite likely needed for the upcoming block library work. Users need a way to categorize stories so they can display stories on their websites for particular topics. We can start with tags only for now, and have them not shared with posts. The feature should be built in an agnostic way independent from specific implementations. In other words, if we ever add a "Country", "Color" or "Whatever" taxonomy, there should be no changes needed to the editor or dashboard. @o-fernandez WDYT? So we need:
Not 100% blocked by UX. For the time being users could just use the "All Stories" view. |
@swissspidy agree that this will be important for the blocks. Curious, though, why would we make this independent from posts? My thinking is - categories and tags are probably something publishers set up to match the different page experiences they want to create, so asking them to set a new taxonomy for these posts may not be great. But, wondering if there are WP reasons for which you recommend not doing this? @amedina and I had discussed this ticket a few weeks ago when talking about embeds and agreed it would be important to do this as part of the enhanced blocks. I think @amedina had some thoughts on how this could work, so may be good to sync on it. My short spec would be (I can put it in a brief)
If this generally sounds good, we can file tickets for 1 (workspace change) and 4 (dashboard change), but LMKWYT. |
I suppose we'll need to refine what the goal of this is. Is it purely for managing content in the backend, or also for showing stories of these categories in the archives? For example, WP by default has archives like
One issue with that is that WordPress will have troubles counting how many content items have a specific category, because by default it only counts posts, not custom post types like stories. Another issue is the archives situation above. |
Bumping due to a FR from NCA, which consists of two user flows:
I think this is pretty close to the existing proposals above, just generalized. |
This is not something we should add to the settings page. This belongs to where taxonomies are registered. Wherever NCA is registering custom taxonomies in their plugin(s), they should just update their register_taxonomy( 'my-cool-taxonomy', [ 'post', 'web-story', 'some-other-post-type' ];
register_taxonomy_for_object_type( 'my-cool-taxonomy', 'web-story' );
This ticket's goal, essentially.
We we would take the list of all taxonomies registered for the web-story post type and display them in the document panel. The UI component being used depends on whether it's hierarchical or not. This is how this works in WP elsewhere and what users and developers would expect here as well. Example UI for hierarchical and non-hierarchical taxonomies in Gutenberg: |
requires UX direction on a multi-select dropdown, |
Is there any update on this? So far, it is still not possible to assign another taxonomy other than the initial to the web-story post type. Is it a possibility? |
@rmetzker You can use code such as the above to assign your custom taxonomies to web stories. There are also plugins that let you do this. We do not provide a UI for this though. |
I was trying to use them but nothing was happening. Neither 'init' nor 'plugins_loaded' was doing the job when calling add_action to register the custom taxonomy. I had to use 'init' with a higher priority to get it to work. It's functional! Thanks @swissspidy |
Feature Description
Document
panel of the editor that allows users to set tags and categories of their story.UI draft from Aug 28, 2021 (where the part on the leftt is what Gutenberg (WordPress) does now and the bit on the right is to implement in the editor):
(March 4, 2020 - original description)
This was taken out of #405
Feature Brief
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria
The text was updated successfully, but these errors were encountered: