Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Beta micro site #2832

Merged
merged 14 commits into from Jul 1, 2020
Merged

Beta micro site #2832

merged 14 commits into from Jul 1, 2020

Conversation

pbakaus
Copy link
Contributor

@pbakaus pbakaus commented Jun 30, 2020 •
edited

Summary

Adds the micro site for the beta in Github Pages under /beta.

To-do

  • There's a placeholder in the top section that @samitron7 still needs to provide.
  • Need to wait for @swissspidy to generate release to replace download link placeholders.
  • CSS clean up. General markup structure should be pretty sound, but the CSS is rapidly coded. Then again, it's a site that will only exist a few weeks..

localhost_web-stories-wp_beta_

Fixes #2650

@pbakaus pbakaus requested a review from swissspidy June 30, 2020 07:33
@swissspidy

This comment has been minimized.

Sign in to view
@pbakaus

This comment has been minimized.

Sign in to view
@pbakaus
Copy link
Contributor Author

pbakaus commented Jun 30, 2020

Alright, getting too sleepy now but managed to squeeze in fluidity on Desktop and a mobile breakpoint for common mobile devices.

@swissspidy

This comment has been minimized.

Sign in to view
@swissspidy swissspidy mentioned this pull request Jun 30, 2020
Merged
@swissspidy swissspidy added the Type: Enhancement New feature or improvement of an existing feature label Jun 30, 2020
@swissspidy
Copy link
Collaborator

@pbakaus FYI fixed the deployment part and made a small config change. Make sure to pull/rebase.

swissspidy
swissspidy reviewed Jun 30, 2020
View reviewed changes
beta/index.html Outdated Show resolved Hide resolved
swissspidy
swissspidy reviewed Jul 1, 2020
View reviewed changes
beta/index.html Outdated Show resolved Hide resolved
swissspidy
swissspidy approved these changes Jul 1, 2020
View reviewed changes
Copy link
Collaborator

@swissspidy swissspidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@pbakaus pbakaus merged commit 99037e8 into gh-pages Jul 1, 2020
@pbakaus pbakaus deleted the beta-micro-site branch July 1, 2020 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swissspidy swissspidy swissspidy approved these changes

Assignees
No one assigned
Labels
Type: Enhancement New feature or improvement of an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pbakaus @swissspidy @googlebot