Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FR: Readme: template.env not provided? #59

Closed
kenrick95 opened this issue Aug 4, 2019 · 3 comments
Closed

FR: Readme: template.env not provided? #59

kenrick95 opened this issue Aug 4, 2019 · 3 comments
Assignees
@xinbenlv
Labels
enhancement New feature or request

Comments

@kenrick95
Copy link

The readme file has the following statement:

A template has been provided in the template.env. Once set, you should do cp template.env .env to create such file in the exact name.

but I cannot find any template.env file in the latest master branch, only a heroku.env, which I don't think is the correct file.

Please help to provide a template.env file, or correct the readme file.

Thanks
@xinbenlv xinbenlv added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Aug 6, 2019
@xinbenlv
Copy link
Contributor

xinbenlv commented Aug 6, 2019

Thank you for reporting. I will address this soon

@xinbenlv xinbenlv self-assigned this Aug 6, 2019
@xinbenlv xinbenlv changed the title Readme: template.env not provided? FR: Readme: template.env not provided? Aug 6, 2019
xinbenlv added a commit that referenced this issue Aug 7, 2019
@xinbenlv
Mega commit, contains fix #60, #59, #58, #57"
0e5c6ec 
> - #57, when multiple commits were conducted by the same user, the revert url redirect to history page so the reviewer can have a better overview.
>   we will further improve this with ROLLBACK feature or ADMIN notice feature in future release when we are granted Oauth
> - #58, package-lock.json rescyned by running `npm i`
> - #59, added template.env
> - #60, the error is caused by when ORES score is not available for an individual revision. We ignore them in this case.
@xinbenlv xinbenlv closed this as completed Aug 7, 2019
@xinbenlv
Copy link
Contributor

xinbenlv commented Aug 8, 2019

Hi @kenrick95 you should now be able to deploy to heroku directly. We also include a template.env FYI. Let me know if this resolves your question

@kenrick95
Copy link
Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xinbenlv xinbenlv

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xinbenlv @kenrick95