Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: run wire with -mod=mod #353

Merged
merged 2 commits into from May 27, 2022
Merged

fix: run wire with -mod=mod #353

merged 2 commits into from May 27, 2022

Conversation

giautm
Copy link
Contributor

@giautm giautm commented Mar 30, 2022

fixed the issue when using wire with Go module.

go run github.com/google/wire/cmd/wire gen
/go/pkg/mod/github.com/google/wire@v0.5.0/cmd/wire/main.go:34:2: missing go.sum entry for module providing package github.com/google/subcommands (imported by github.com/google/wire/cmd/wire); to add:
        go get github.com/google/wire/cmd/wire@v0.5.0

Close: #299, #342

@giautm
Copy link
Contributor Author

giautm commented Mar 30, 2022

hi @eliben. Can you review this PR, please?

@giautm
Copy link
Contributor Author

giautm commented Apr 5, 2022

hello @eliben, are you there?

@eliben
Copy link
Member

eliben commented Apr 5, 2022

We're quite busy right now and working to figure out who the right person to review this would be. Please respect that this is an open source project that's offered to the community for free and in good will.

Thanks for the understanding

@giautm
Copy link
Contributor Author

giautm commented Apr 5, 2022

Thank you for your response, I understand what you mean.

This is my first time contributing to this project, so just wanted to get some attention from the team for the review.

Again, thank you very much. I will wait patiently for a response. Have a nice day!

@giautm
Copy link
Contributor Author

giautm commented May 10, 2022

Hello @vangent. sorry to bother you, but can you help me review this PR?

@eliben
Copy link
Member

eliben commented May 10, 2022

@stytchiz @jayzhuang @syodage

@stytchiz
Copy link
Collaborator

It seems this error happens after running go mod tidy.

 % go get github.com/google/wire/cmd/wire
 % go mod tidy -v
unused github.com/google/subcommands
unused github.com/pmezard/go-difflib
unused golang.org/x/tools

These are indirect dependencies. https://go.dev/issue/27664 seems relevant. Apparently the removal of these dependencies is intentional. Therefore this does seem like a simple fix to unblock "go generate" ... so LGTM.

It's still unclear to me why this is not an issue when running the "wire" binary directly.

@giautm
Copy link
Contributor Author

giautm commented May 17, 2022

hello @eliben, can you merge and release this PR please?

@eliben
Copy link
Member

eliben commented May 17, 2022

The folks I've CCd on this issue in a previous comment all volunteered to maintain wire and are able to merge PRs.

@jayzhuang
Copy link
Collaborator

Hey @eliben, I think I only have triage rights, not write access, so I can't merge PRs.

@stytchiz stytchiz merged commit f5e937d into google:main May 27, 2022
@giautm giautm deleted the patch-1 branch May 28, 2022 13:03
@giautm
Copy link
Contributor Author

giautm commented Mar 27, 2023

Hello, this PR is 1 year old. Do you consider making a release for it?

black-desk added a commit to black-desk/checks that referenced this pull request Oct 20, 2023
FUCK Google

google/wire#353
google/wire#364 (comment)

This reverts commit c7b1290.

Signed-off-by: black-desk <me@black-desk.cn>
jrc2139 added a commit to arrakis-digital/wire that referenced this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing go.sum entry after ran go mod tidy
4 participants