Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer split named arguments rather than lists #691

Open
apbard opened this issue Mar 19, 2019 · 0 comments
Open

Prefer split named arguments rather than lists #691

apbard opened this issue Mar 19, 2019 · 0 comments

Comments

@apbard
Copy link
Contributor

apbard commented Mar 19, 2019

[style]
based_on_style=chromium
split_before_named_assigns=False

When there are lists as arguments yapf seems to adopt a weird splitting:

def fooooooooooooo(aka=['aaaaaaaa', 'aaaaaaa', 'aaaa', 'aa',
                        'a'], types=['double', 'bool'],
                   validator=some_looooooooooong_name):
    pass


def fooooooooooooo(type01=aaaaaa, type02=['double'], type03=['double'],
                   aka=['aaaaaaaa', 'aaaaaaa', 'aaaa', 'aa',
                        'a'], aaaaa=['double', 'bool'],
                   validator=some_looooooooooong_name):
    pass

instead I would prefer:

def fooooooooooooo(aka=['aaaaaaaa', 'aaaaaaa', 'aaaa', 'aa', 'a'], 
                   types=['double', 'bool'],
                   validator=some_looooooooooong_name):
    pass


def fooooooooooooo(type01=aaaaaa, type02=['double'], type03=['double'],
                   aka=['aaaaaaaa', 'aaaaaaa', 'aaaa', 'aa', 'a'], 
                   aaaaa=['double', 'bool'],
                   validator=some_looooooooooong_name):
    pass
@apbard apbard changed the title Prefer not splitting up list Prefer split named arguments rather than lists Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant