Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent os.walk() scanning excluded dirs. #898

Merged
merged 1 commit into from
Feb 5, 2021

Conversation

bwoodsend
Copy link
Contributor

Rather than discovering every file then eliminating those in excluded folders, this eliminates searching the excluded folders to begin with.

This is a big speedup if you have an exlcuded virtual environment sat in a repository.

@google-cla google-cla bot added the cla: yes label Feb 5, 2021
@coveralls
Copy link

coveralls commented Feb 5, 2021

Coverage Status

Coverage decreased (-0.02%) to 94.483% when pulling e6c0c02 on bwoodsend:skip-walking-excluded-dirs into 503bc40 on google:main.

@bwendling bwendling merged commit a53e340 into google:main Feb 5, 2021
@bwendling
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants