Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In zerocopy-derive UI tests, detect whether we're building with RUSTFLAGS='-Wwarnings' #953

Open
joshlf opened this issue Feb 26, 2024 · 0 comments
Labels
experience-easy This issue is easy, and shouldn't require much experience help wanted Extra attention is needed

Comments

@joshlf
Copy link
Member

joshlf commented Feb 26, 2024

This is how we run zerocopy-derive's UI tests in CI, and so if a developer locally runs UI tests treating warnings as errors, they will generate the wrong .stderr files, and CI will fail.

If RUSTFLAGS='-Wwarnings' is absent the test harness should eagerly fail with a single descriptive error, rather than proceed to run UI tests (which will produce lots of errors).

For those interested in tackling this, the file to look in is: https://github.com/google/zerocopy/blob/main/zerocopy-derive/tests/trybuild.rs

@joshlf joshlf added help wanted Extra attention is needed experience-easy This issue is easy, and shouldn't require much experience labels Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
experience-easy This issue is easy, and shouldn't require much experience help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant