Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lag when scrolling listview with banner ads (IOS only) #892

Closed
OmerTrainer opened this issue Jul 23, 2023 · 10 comments
Closed

lag when scrolling listview with banner ads (IOS only) #892

OmerTrainer opened this issue Jul 23, 2023 · 10 comments
Labels
invalid This doesn't seem right

Comments

@OmerTrainer
Copy link

[REQUIRED] Step 1: Describe your environment

Plugin Version

google_mobile_ads: ^3.0.0

[REQUIRED] Step 2: Describe the problem

Steps to Reproduce

https://github.com/OmerTrainer/one-sampleapp-ads

  1. clone sample app.
  2. import your own ca-app-pub in the ios runner info.plist file.
  3. run the app on physical ios device. (the newer ones, i personally run it with Iphone 14+).
  4. scroll inside the app and notice the lag when scrolling.

Expected results:
smoothly scrolling screen displaying the banner ads.

Actual results:
choppy / laggy scrolling screen when displaying the banner ads.

[✓] Flutter (Channel stable, 3.10.4, on macOS 13.3.1 22E772610a darwin-arm64, locale en-IL)
• Flutter version 3.10.4 on channel stable at /Users/developer/Documents/ONEAPP/Plugins/flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision 682aa387cf (7 weeks ago), 2023-06-05 18:04:56 -0500
• Engine revision 2a3401c9bb
• Dart version 3.0.3
• DevTools version 2.23.1

@cyanglaz
Copy link
Contributor

Could you provide the iOS version on your iPhone?

@OmerTrainer
Copy link
Author

OmerTrainer commented Jul 25, 2023

@cyanglaz

yes, sorry for the missing information..
I am currently on 16.3 IOS version

@huycozy huycozy added the in triage Issue currently being evaluated label Jul 25, 2023
@huycozy
Copy link
Collaborator

huycozy commented Jul 25, 2023

Hi @OmerTrainer

I checked this issue on my device iPhone 7, iOS 15.7.2 (I have only this one) but it isn't laggy when scrolling:

Demo video
Image.from.iOS.MP4

Can you please try running the app in profile mode to see if it's still laggy? It would be appreciated if you could provide a recorded video so we can notice how lag it is. Thank you!

@huycozy huycozy added the feedback required Further information is requested label Jul 25, 2023
@OmerTrainer
Copy link
Author

Hi @OmerTrainer

I checked this issue on my device iPhone 7, iOS 15.7.2 (I have only this one) but it isn't laggy when scrolling:

Demo video
Image.from.iOS.MP4
Can you please try running the app in profile mode to see if it's still laggy? It would be appreciated if you could provide a recorded video so we can notice how lag it is. Thank you!

on older devices the lag doesn't appear this is why i said that it should be ran on newer physical ios device(13/14).
(it was filmed with profile build iphone 14+ physical device)
i hope that the attached videos will help :

WhatsApp.Video.2023-07-25.at.15.21.04.mp4
WhatsApp.Video.2023-07-25.at.15.21.06.mp4

@github-actions github-actions bot removed the feedback required Further information is requested label Jul 25, 2023
@huycozy
Copy link
Collaborator

huycozy commented Jul 26, 2023

Thanks for the videos. It looks smooth, though. Can you please enable performance overlay in profile mode to see if there are any jank? And please also attach the timeline trace JSON file as well. You can find the instructions for it at flutter/flutter#74833 (comment).

@quan2nd
Copy link

quan2nd commented Jul 26, 2023

I also encountered this issue on iOS. The first time I run the application, everything is very smooth. However, after I kill the app or run it for the second time and onwards, my listview becomes laggy. I use all the latest versions(IOS, Flutter, GoogleAds)
On a simulator it is easier to notice the lag

@lucalooz
Copy link

lucalooz commented Aug 3, 2023

I think this can be related to flutter/flutter#129632

@quan2nd
Copy link

quan2nd commented Aug 10, 2023

@OmerTrainer Try turning off Impeller
https://docs.flutter.dev/perf/impeller
I solved my problem

@OmerTrainer
Copy link
Author

@OmerTrainer Try turning off Impeller https://docs.flutter.dev/perf/impeller I solved my problem

I have already tried it didn't resolve the issue

@github-actions github-actions bot removed the feedback required Further information is requested label Aug 13, 2023
@huycozy
Copy link
Collaborator

huycozy commented Aug 14, 2023

@llooz Thanks for linking the issue. It seems that's indeed related issue when the OP also mentioned in the first comment (specific OS, device). Also, it's not an Impeller issue (you can check at that issue's labels), it's a platform-views issue.

I will close this in favor of Flutter issue flutter/flutter#129632. Please follow up on it for further updates.

@huycozy huycozy closed this as not planned Won't fix, can't repro, duplicate, stale Aug 14, 2023
@huycozy huycozy added invalid This doesn't seem right and removed in triage Issue currently being evaluated labels Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

5 participants