Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong instantiation of urllib2.HTTPSHandler #122

Closed
sfontana opened this issue May 23, 2016 · 2 comments
Closed

Wrong instantiation of urllib2.HTTPSHandler #122

sfontana opened this issue May 23, 2016 · 2 comments

Comments

@sfontana
Copy link

Here 5820c98#diff-16683aec6de1b227110863506f6fb267R380

handlers.append(urllib2.HTTPSHandler(self._ssl_context)) is wrong because HTTPSHandler has debuglevel as first parameter

 class HTTPSHandler(AbstractHTTPHandler):

        def __init__(self, debuglevel=0, context=None):
            AbstractHTTPHandler.__init__(self, debuglevel)
            self._context = context

please correct line 380 to handlers.append(urllib2.HTTPSHandler(context=self._ssl_context))

Isn't this a security issue too?

@nicholaschen
Copy link
Contributor

Heya,

Thanks for reporting this, lemme take a closer look at this and see if we can't correct it 👍

@msaniscalchi
Copy link
Contributor

Hello,

Thanks for the report, we'll have this corrected soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants