-
Notifications
You must be signed in to change notification settings - Fork 978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OfflineDataUploadService doesn't seem to be implemented. #228
Comments
Hello Steve, The linked docs indicate this is a whitelist-only feature. It's possible that you're not included in that whitelist, which would explain why you're having trouble making API calls. It's not unusual for the library to include whitelisted services like this, so I think this is working as intended. Regards, |
I am aware this is a whitelisted feature. If you look at the implementation, there is only one reference to OfflineDataUploadService in the code base, namely in the _SERVICE_MAP. There doesn't seem to be any other code to implement the service or any code implementing the arguments necessary to make the calls to the service, e.g. OfflineData. I notice some of the other API implementations, PHP and Java for example, seem to have more complete support for OfflineDataUploadService. We will switch to one of these implementations if necessary, but would prefer to use Python. |
Yes, this doesn't sound unusual. This library isn't generated like the Java client library, it downloads the wsdl (or retrieves it from cache) and creates the service dynamically. Consequently, this library also doesn't have generated DTOs for API objects like OfflineData. We use suds, which does offer some factories to produce these, we discuss this a bit here. |
We get the following error:
Is this what we should expect if we are not correctly accessing our whitelisted account? The documents imply I should receive a NotWhitelistedError |
Thanks for following up Steve. It looks like you uncovered an issue that I'm surprised wasn't discovered earlier. This is the actual wsdl URL: This is the wsdl URL being used: It appears that an error was made when this service was added to We're going to be releasing a new AdWords version soon, so we'll include the fix in that release. Regards, |
Patching the wsdl URL works!
Now I just need to bone up on suds. Thanks. |
The OfflineDataUploadService and OfflineData do not seem to be implemented.
See the following for details:
https://developers.google.com/adwords/api/docs/reference/v201708/OfflineDataUploadService
The text was updated successfully, but these errors were encountered: