feat: adds a request mode for ad requests

onLoad: This is the default behaviour, ad requests are done when the player is ready onPlay: New behaviour, Ad requests are only made once playback is initiated. This is necessary as some ad networks consider ad requests to be plays
googleads · Jan 29, 2019 · 278556b · 278556b
1 parent e0d59f5
commit 278556b
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/src/controller.js b/src/controller.js
@@ -86,6 +86,7 @@ Controller.IMA_DEFAULTS = {
   adLabel: 'Advertisement',
   adLabelNofN: 'of',
   showControlsForJSAds: true,
+  requestMode: 'onLoad',
 };
 
 /**

diff --git a/src/player-wrapper.js b/src/player-wrapper.js
@@ -139,6 +139,11 @@ const PlayerWrapper = function(player, adsPluginSettings, controller) {
   this.vjsPlayer.on('readyforpreroll', this.onReadyForPreroll.bind(this));
   this.vjsPlayer.ready(this.onPlayerReady.bind(this));
 
+  if (this.controller.getSettings().requestMode === 'onPlay') {
+      this.vjsPlayer.one('play',
+      this.controller.requestAds.bind(this.controller));
+}
+
   this.vjsPlayer.ads(adsPluginSettings);
 };
 

diff --git a/src/sdk-impl.js b/src/sdk-impl.js
@@ -553,9 +553,10 @@ SdkImpl.prototype.onPlayerReadyForPreroll = function() {
 SdkImpl.prototype.onPlayerReady = function() {
   this.initAdObjects();
 
-  if (this.controller.getSettings().adTagUrl ||
-      this.controller.getSettings().adsResponse) {
-    this.requestAds();
+  if ((this.controller.getSettings().adTagUrl ||
+      this.controller.getSettings().adsResponse) &&
+      this.controller.getSettings().requestMode === 'onLoad') {
+        this.requestAds();
   }
 };