fix: Call startLinearAdMode on post-rolls. Fixes an issue where contr…

…ib-ads thought we were timing out on all post-rolls.\Fixes #620. (#631)
googleads · May 31, 2018 · 6088f86 · 6088f86
1 parent b6dbc62
commit 6088f86
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 9 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/src/controller.js b/src/controller.js
@@ -294,7 +294,7 @@ Controller.prototype.onAdError = function(adErrorEvent) {
  * @param {Object} adEvent The event fired by the IMA SDK.
  */
 Controller.prototype.onAdBreakStart = function(adEvent) {
-  this.playerWrapper.onAdBreakStart(adEvent);
+  this.playerWrapper.onAdBreakStart();
   this.adUi.onAdBreakStart(adEvent);
 };
 

diff --git a/src/player-wrapper.js b/src/player-wrapper.js
@@ -456,16 +456,11 @@ PlayerWrapper.prototype.onAdError = function(adErrorEvent) {
 
 /**
  * Handles ad break starting.
- *
- * @param {Object} adEvent The event fired by the IMA SDK.
  */
-PlayerWrapper.prototype.onAdBreakStart = function(adEvent) {
+PlayerWrapper.prototype.onAdBreakStart = function() {
   this.contentSource = this.vjsPlayer.currentSrc();
   this.vjsPlayer.off('contentended', this.boundContentEndedListener);
-  if (adEvent.getAd().getAdPodInfo().getPodIndex() != -1) {
-    // Skip this call for post-roll ads
-    this.vjsPlayer.ads.startLinearAdMode();
-  }
+  this.vjsPlayer.ads.startLinearAdMode();
   this.vjsControls.hide();
   this.vjsPlayer.pause();
 };