fix: Wait until PlayerWrapper ready before invoking SdkImpl.initAdObj…

…ects (#638)
googleads · Jun 6, 2018 · fd409d6 · fd409d6
1 parent 9701135
commit fd409d6
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 7 deletions.
diff --git a/src/controller.js b/src/controller.js
@@ -482,6 +482,14 @@ Controller.prototype.onPlayerReadyForPreroll = function() {
 };
 
 
+/**
+ * Called when the player is ready.
+ */
+Controller.prototype.onPlayerReady = function() {
+  this.sdkImpl.onPlayerReady();
+};
+
+
 /**
  * Called when the player enters fullscreen.
  */

diff --git a/src/player-wrapper.js b/src/player-wrapper.js
@@ -278,6 +278,8 @@ PlayerWrapper.prototype.onPlayerReady = function() {
   this.onVolumeChange();
   this.vjsPlayer.on('fullscreenchange', this.onFullscreenChange.bind(this));
   this.vjsPlayer.on('volumechange', this.onVolumeChange.bind(this));
+
+  this.controller.onPlayerReady();
 };
 
 

diff --git a/src/sdk-impl.js b/src/sdk-impl.js
@@ -142,13 +142,6 @@ const SdkImpl = function(controller) {
     google.ima.settings.setDisableCustomPlaybackForIOS10Plus(
         this.controller.getSettings().disableCustomPlaybackForIOS10Plus);
   }
-
-  this.initAdObjects();
-
-  if (this.controller.getSettings().adTagUrl ||
-      this.controller.getSettings().adsResponse) {
-    this.requestAds();
-  }
 };
 
 
@@ -533,6 +526,15 @@ SdkImpl.prototype.onPlayerReadyForPreroll = function() {
   }
 };
 
+SdkImpl.prototype.onPlayerReady = function() {
+  this.initAdObjects();
+
+  if (this.controller.getSettings().adTagUrl ||
+      this.controller.getSettings().adsResponse) {
+    this.requestAds();
+  }
+};
+
 
 SdkImpl.prototype.onPlayerEnterFullscreen = function() {
   if (this.adsManager) {