Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix advanced sample for mobile. #469

Merged
merged 1 commit into from Jan 2, 2018
Merged

fix: Fix advanced sample for mobile. #469

merged 1 commit into from Jan 2, 2018

Conversation

shawnbuso
Copy link
Contributor

Fixes #468

ypavlotsky
ypavlotsky reviewed Dec 20, 2017
View reviewed changes
Copy link
Contributor

@ypavlotsky ypavlotsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this required?

@shawnbuso
Copy link
Contributor Author

The ID of the video element isn't set until you create the vjs player instance. So we need to create that instance before calling var contentPlayer = document.getElementById('content_video_html5_api'.

@shawnbuso shawnbuso merged commit c0c4bee into googleads:master Jan 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ypavlotsky ypavlotsky ypavlotsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shawnbuso @ypavlotsky