Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix locale and numRedirects settings #584

Merged
merged 1 commit into from Mar 28, 2018

Conversation

cmellinas
Copy link
Contributor

On the new version of this plugin, locale and numRedirects settings are not passed correctly to IMA SDK, it will send "undefined" to IMA SDK and can lead to errors increase(if you use numRedirects).

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@cmellinas
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@shawnbuso shawnbuso merged commit e4de93d into googleads:master Mar 28, 2018
@shawnbuso
Copy link
Contributor

Thanks for the fix!

bustbr pushed a commit to bustbr/videojs-ima that referenced this pull request Apr 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants