Multilingual UI support for the adLabel "N of N" string #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
|
I signed it! |
|
CLAs look good, thanks! |
shawnbuso
reviewed
Apr 16, 2018
src/ad-ui.js
Outdated
| @@ -268,7 +268,7 @@ AdUi.prototype.updateAdUi = | |||
| } | |||
| let podCount = ': '; | |||
| if (totalAds > 1) { | |||
| podCount = ' (' + adPosition + ' of ' + totalAds + '): '; | |||
| podCount = ' (' + adPosition + ' ' + this.controller.getSettings().adLabelNofN + ' ' + totalAds + '): '; | |||
There was a problem hiding this comment.
Line too long - max length is 80 characters.
|
Should be ok now. |
shawnbuso
suggested changes
Apr 17, 2018
src/ad-ui.js
Outdated
| @@ -268,7 +268,8 @@ AdUi.prototype.updateAdUi = | |||
| } | |||
| let podCount = ': '; | |||
| if (totalAds > 1) { | |||
| podCount = ' (' + adPosition + ' of ' + totalAds + '): '; | |||
| podCount = ' (' + adPosition + ' ' + | |||
| this.controller.getSettings().adLabelNofN + ' ' + totalAds + '): '; | |||
There was a problem hiding this comment.
Can you indent this line 4 spaces? That falls in line with our style guide. Then we should be good to go. Thanks!
shawnbuso
approved these changes
Apr 18, 2018
bustbr
pushed a commit
to bustbr/videojs-ima
that referenced
this pull request
Apr 24, 2018
…ads#592) * Multilingual UI support for the adLabel "N of N" string * Multilingual UI support for the adLabel "N of N" string - correct line max length * Multilingual UI support for the adLabel "N of N" string - correct indentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess this would be useful for other users.