Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BrowserStack tests #616

Closed
shawnbuso opened this issue May 16, 2018 · 3 comments
Closed

Fix BrowserStack tests #616

shawnbuso opened this issue May 16, 2018 · 3 comments
Assignees
Labels

Comments

@shawnbuso
Copy link
Contributor

The BrowserStack tests are super flaky and fail at random with every run. They're currently disabled - let's fix them and re-enable them.

@mysuf
Copy link

mysuf commented Jun 5, 2018

One recommendation based on my experiences:
I had to add player.ready to tests as videojs is growing and it takes too long to load and properly handle webdriver click (with v6.10.0 firefox always failed in random tests). This fixed it for me:

ads.js

player.ready(function() {
  var log = document.getElementById('log');
  log.innerHTML += "ready<br>"; 
});

basic.js:

let log = await driver.findElement(By.id('log'));
await driver.wait(until.elementTextContains(log, 'ready'), 10000);
await driver.findElement(By.id('content_video')).click();
....

@mysuf
Copy link

mysuf commented Jun 8, 2018

You can also try newer version of geckodriver, but looking at browserstack waiting times(across both drivers), this seems more like really poor browserstack HW/connection capabilities..

@ypavlotsky
Copy link
Contributor

Fixed with #657

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants