Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve player dimension accuracy in certain cases #623

Merged
merged 1 commit into from May 21, 2018

Conversation

jplhomer
Copy link
Contributor

In PR #418, the use of getComputedStyle was replaced with getBoundingClientRect in order to support IE11.

However, this breaks implementations where the video is being scaled using transforms because getBoundingClientRect returns the scaled output, not the original output.

image

This PR updates the getPlayerWidth and getPlayerHeight methods to use getComputedStyle and fall back to getBoundingClientRect when necessary. This allows us to support scaled videos, normal videos, and fluid sizing on IE11.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@shawnbuso shawnbuso self-requested a review May 21, 2018 14:49
@googlebot
Copy link

CLAs look good, thanks!

@shawnbuso shawnbuso merged commit a017044 into googleads:master May 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants