refactor: Deprecated id setting, instead get the id from Vjs player. #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawnbuso
suggested changes
May 23, 2018
src/player-wrapper.js
Outdated
| @@ -266,7 +266,7 @@ PlayerWrapper.prototype.onReadyForPreroll = function() { | |||
| PlayerWrapper.prototype.onPlayerReady = function() { | |||
| this.h5Player = | |||
| document.getElementById( | |||
| this.controller.getSettings().id).getElementsByClassName( | |||
| this.controller.getPlayerId()).getElementsByClassName( | |||
There was a problem hiding this comment.
This is the same class - can't we just put this.getPlayerId() here and leave the controller out of it?
shawnbuso
approved these changes
May 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.