Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: please provide a SCSS source file #636

Closed
axten opened this issue Jun 5, 2018 · 4 comments
Closed

Feature: please provide a SCSS source file #636

axten opened this issue Jun 5, 2018 · 4 comments
Assignees
@shawnbuso
Labels
enhancement

Comments

@axten
Copy link

axten commented Jun 5, 2018

Because of node-sass dropping support for importing css files, it would be great to have an scss source file to include.

see sass/node-sass#2362
@shawnbuso shawnbuso self-assigned this Jun 5, 2018
@shawnbuso
Copy link
Contributor

I'm not super familiar with SCSS, but it looks like it supports CSS - if I just made a copy of videojs.ima.css and named it videojs.ima.scss, would that work?

@axten
Copy link
Author

axten commented Jun 5, 2018

yes this would work, because sass is a superset of css.

@axten
Copy link
Author

axten commented Jun 7, 2018

cool! when is the next released scheduled?

@shawnbuso
Copy link
Contributor

We don't have a set schedule - I can cut one once the 2 most recent PRs in the open PR list have been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shawnbuso shawnbuso

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shawnbuso @axten