Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Wait until PlayerWrapper ready before invoking SdkImpl.initAdObjects #638

Merged
merged 1 commit into from Jun 6, 2018

Conversation

gawhyte
Copy link
Contributor

@gawhyte gawhyte commented Jun 6, 2018

Fixes #633

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@gawhyte
Copy link
Contributor Author

gawhyte commented Jun 6, 2018 via email

@googlebot
Copy link

CLAs look good, thanks!

@shawnbuso shawnbuso merged commit fd409d6 into googleads:master Jun 6, 2018
@shawnbuso
Copy link
Contributor

Thanks!

@sdahdaah
Copy link

sdahdaah commented Jun 8, 2018

issue not fixed.

@shawnbuso
Copy link
Contributor

@sdahdaah can you give us more info on where you're seeing this and how we can reproduce it?

@sdahdaah
Copy link

Hello,

After upgrading to the latest controb-ads and latest ima ads on iOS iPhone plays in background when in full screen. using IMA 1.3.0 works with no issue even with latest contrib-ads the problem is with IMA 1.4.0 where ads on iPhone plays in background while in full screen and plays with no issue when playback is inline only.

So create a player with IMA 1.4.0 open the link from an iPhone NOT IPAD, click full screen as soon as the ad starts you will hear it but not see it as it is running in background.

Regards,

@shawnbuso
Copy link
Contributor

Thanks for the info - I've added that to the initial bug, we can continue to troubleshoot there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants