New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Wait until PlayerWrapper ready before invoking SdkImpl.initAdObjects #638
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it!
…On Wed, Jun 6, 2018 at 11:00 AM, googlebot ***@***.***> wrote:
Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project (if not, look below for help).
Before we can look at your pull request, you'll need to sign a Contributor
License Agreement (CLA).
📝 *Please visit https://cla.developers.google.com/
<https://cla.developers.google.com/> to sign.*
Once you've signed (or fixed any issues), please reply here (e.g. I
signed it!) and we'll verify it.
------------------------------
What to do if you already signed the CLA Individual signers
- It's possible we don't have your GitHub username or you're using a
different email address on your commit. Check your existing CLA data
<https://cla.developers.google.com/clas> and verify that your email is
set on your git commits
<https://help.github.com/articles/setting-your-email-in-git/>.
Corporate signers
- Your company has a Point of Contact who decides which employees are
authorized to participate. Ask your POC to be added to the group of
authorized contributors. If you don't know who your Point of Contact is,
direct the Google project maintainer to go/cla#troubleshoot (Public
version <https://opensource.google.com/docs/cla/#troubleshoot>).
- The email used to register you as an authorized contributor must be
the email used for the Git commit. Check your existing CLA data
<https://cla.developers.google.com/clas> and verify that your email is
set on your git commits
<https://help.github.com/articles/setting-your-email-in-git/>.
- The email used to register you as an authorized contributor must
also be attached to your GitHub account
<https://github.com/settings/emails>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#638 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ANBHc5C6uIqXKyADRdlR9Jcr-PO41FYfks5t5-6ngaJpZM4Uc0hQ>
.
--
Greg Whyte
Developer / Designer
307.287.8909
greg.a.whyte@gmail.com
|
CLAs look good, thanks! |
Thanks! |
issue not fixed. |
@sdahdaah can you give us more info on where you're seeing this and how we can reproduce it? |
Hello, After upgrading to the latest controb-ads and latest ima ads on iOS iPhone plays in background when in full screen. using IMA 1.3.0 works with no issue even with latest contrib-ads the problem is with IMA 1.4.0 where ads on iPhone plays in background while in full screen and plays with no issue when playback is inline only. So create a player with IMA 1.4.0 open the link from an iPhone NOT IPAD, click full screen as soon as the ad starts you will hear it but not see it as it is running in background. Regards, |
Thanks for the info - I've added that to the initial bug, we can continue to troubleshoot there. |
Fixes #633