Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timeouts - now 60000 ms #672

Merged
merged 8 commits into from Jun 22, 2018
Merged

Timeouts - now 60000 ms #672

merged 8 commits into from Jun 22, 2018

Conversation

ypavlotsky
Copy link
Contributor

No description provided.

shawnbuso
shawnbuso suggested changes Jun 21, 2018
View reviewed changes
Copy link
Contributor

@shawnbuso shawnbuso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this.slow(15000) need to be updated?

ypavlotsky
ypavlotsky commented Jun 21, 2018
View reviewed changes
Copy link
Contributor Author

@ypavlotsky ypavlotsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would argue that anything over 15000 ms is 'slow', even still.

@shawnbuso
Copy link
Contributor

Ah OK I didn't know what that actually did - LGTM

@ypavlotsky ypavlotsky merged commit fc81aae into googleads:master Jun 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawnbuso shawnbuso shawnbuso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ypavlotsky @shawnbuso