Skip to content
This repository has been archived by the owner on Apr 3, 2024. It is now read-only.

Commit

Permalink
Lint and yarn (#301)
Browse files Browse the repository at this point in the history 
* update yarn.lock
* fix lint errors
  • Loading branch information
@ofrobots
ofrobots committed Jul 6, 2017
1 parent 7ccdcd7 commit 2297c09
Show file tree
Hide file tree
Showing 6 changed files with 97 additions and 16 deletions.
2 changes: 1 addition & 1 deletion src/agent/debuglet.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,7 @@ export class Debuglet extends EventEmitter {
// named `response`) is not used.
metadata.project(
'project-id',
function(err: Error, _: http.ServerResponse, metadataProject: string) {
function(err: Error, _res: http.ServerResponse, metadataProject: string) {
// We should get an error if we are not on GCP.
const onGCP = !err;

Expand Down
8 changes: 4 additions & 4 deletions src/agent/scanner.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,8 @@ class ScanResultsImpl implements ScanResults {
* attributes respectively
* @constructor
*/
constructor(stats: ScanStats) {
this.stats_ = stats;
constructor(statsParm: ScanStats) {
this.stats_ = statsParm;
}

/**
Expand All @@ -77,7 +77,7 @@ class ScanResultsImpl implements ScanResults {
* should be included in the returned results.
*/
selectStats(regex: RegExp): ScanStats|{} {
return _.pickBy(this.stats_, function(_, key) {
return _.pickBy(this.stats_, function(_ignore, key) {
return regex.test(key);
});
}
Expand Down Expand Up @@ -207,7 +207,7 @@ function findFiles(
return;
});

find.on('directory', function(dir: string, _: fs.Stats, stop: () => void) {
find.on('directory', function(dir: string, _ignore: fs.Stats, stop: () => void) {
const base = path.basename(dir);
if (base === '.git' || base === 'node_modules') {
stop(); // do not descend
Expand Down
4 changes: 2 additions & 2 deletions src/agent/sourcemapper.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,9 @@ export function create(
callback: (err: Error|null, mapper?: SourceMapper) => void): void {
const mapper = new SourceMapper();
const callList =
Array.prototype.slice.call(sourcemapPaths).map(function(path: string) {
Array.prototype.slice.call(sourcemapPaths).map(function(p: string) {
return function(cb: (err: Error|null) => void) {
processSourcemap(mapper.infoMap_, path, cb);
processSourcemap(mapper.infoMap_, p, cb);
};
});

Expand Down
4 changes: 2 additions & 2 deletions src/agent/state.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ class StateResolver {
// Evaluate the watch expressions
const evalIndexSet = new Set();
if (that.expressions_) {
that.expressions_.forEach(function(expression, index) {
that.expressions_.forEach(function(expression, index2) {
const result = evaluate(expression, that.state_.frame(0));
let evaluated;

Expand All @@ -174,7 +174,7 @@ class StateResolver {
evalIndexSet.add(varTableIdx);
}
}
that.evaluatedExpressions_[index] = evaluated;
that.evaluatedExpressions_[index2] = evaluated;
});
}

Expand Down
2 changes: 1 addition & 1 deletion src/agent/v8debugapi.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ export function create(
let timesliceEnd = Date.now() + 1000;
// TODO: Determine why the Error argument is not used.
const listener =
onBreakpointHit.bind(null, breakpoint, function(_: Error) {
onBreakpointHit.bind(null, breakpoint, function(_err: Error) {
const currTime = Date.now();
if (currTime > timesliceEnd) {
logsThisSecond = 0;
Expand Down
93 changes: 87 additions & 6 deletions yarn.lock
View file
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,40 @@
normalize-path "^2.0.1"
through2 "^2.0.3"

"@types/acorn@^4.0.2":
version "4.0.2"
resolved "https://registry.yarnpkg.com/@types/acorn/-/acorn-4.0.2.tgz#5c37dade857a53c14258c914d43e634076aec3fd"
dependencies:
"@types/estree" "*"

"@types/async@^2.0.40":
version "2.0.40"
resolved "https://registry.yarnpkg.com/@types/async/-/async-2.0.40.tgz#ac02de68e66c004a61b7cb16df8b1db3a254cca9"

"@types/estree@*", "@types/estree@0.0.35":
version "0.0.35"
resolved "https://registry.yarnpkg.com/@types/estree/-/estree-0.0.35.tgz#8999974b34028686a8d61a719e61c138d3755107"

"@types/extend@^2.0.30":
version "2.0.30"
resolved "https://registry.yarnpkg.com/@types/extend/-/extend-2.0.30.tgz#58cc93f621d0a358d3fec9bd6e739bc60ec7e275"

"@types/lodash@^4.14.66":
version "4.14.68"
resolved "https://registry.yarnpkg.com/@types/lodash/-/lodash-4.14.68.tgz#754fbab68bd2bbb69547dc8ce7574f7012eed7f6"

"@types/node@^7.0.18":
version "7.0.18"
resolved "https://registry.yarnpkg.com/@types/node/-/node-7.0.18.tgz#cd67f27d3dc0cfb746f0bdd5e086c4c5d55be173"

"@types/semver@^5.3.31":
version "5.3.32"
resolved "https://registry.yarnpkg.com/@types/semver/-/semver-5.3.32.tgz#a7afdc4bee713c081114cd811b51be10907d7bae"

"@types/source-map@^0.5.0":
version "0.5.0"
resolved "https://registry.yarnpkg.com/@types/source-map/-/source-map-0.5.0.tgz#dd34bbd8e32fe4e74f2e3d8ac07f8aa5b45a47ac"

abbrev@1, abbrev@1.0.x:
version "1.0.9"
resolved "https://registry.yarnpkg.com/abbrev/-/abbrev-1.0.9.tgz#91b4792588a7738c25f35dd6f63752a2f8776135"
Expand Down Expand Up @@ -186,6 +216,14 @@ aws4@^1.2.1:
version "1.6.0"
resolved "https://registry.yarnpkg.com/aws4/-/aws4-1.6.0.tgz#83ef5ca860b2b32e4a0deedee8c771b9db57471e"

babel-code-frame@^6.22.0:
version "6.22.0"
resolved "https://registry.yarnpkg.com/babel-code-frame/-/babel-code-frame-6.22.0.tgz#027620bee567a88c32561574e7fd0801d33118e4"
dependencies:
chalk "^1.1.0"
esutils "^2.0.2"
js-tokens "^3.0.0"

balanced-match@^1.0.0:
version "1.0.0"
resolved "https://registry.yarnpkg.com/balanced-match/-/balanced-match-1.0.0.tgz#89b4d199ab2bee49de164ea02b89ce462d71b767"
Expand Down Expand Up @@ -282,7 +320,7 @@ center-align@^0.1.1:
deep-eql "^0.1.3"
type-detect "^1.0.0"

chalk@^1.0.0, chalk@^1.1.1, chalk@~1.1.3:
chalk@^1.0.0, chalk@^1.1.0, chalk@^1.1.1, chalk@~1.1.3:
version "1.1.3"
resolved "https://registry.yarnpkg.com/chalk/-/chalk-1.1.3.tgz#a8115c55e4a702fe4d150abd3872822a7e09fc98"
dependencies:
Expand All @@ -309,7 +347,7 @@ changelog-maker@^2.2.2:
pkg-to-id "~0.0.3"
split2 "~2.1.1"

clang-format@^1.0.32:
clang-format@^1.0.32, clang-format@^1.0.53:
version "1.0.53"
resolved "https://registry.yarnpkg.com/clang-format/-/clang-format-1.0.53.tgz#ff3668c40ecceeeeaa3e977b61d50106d0b3fd46"
dependencies:
Expand Down Expand Up @@ -367,6 +405,10 @@ coffee-script@^1.9.3:
version "1.12.6"
resolved "https://registry.yarnpkg.com/coffee-script/-/coffee-script-1.12.6.tgz#285a3f7115689065064d6bf9ef4572db66695cbf"

colors@^1.1.2:
version "1.1.2"
resolved "https://registry.yarnpkg.com/colors/-/colors-1.1.2.tgz#168a4701756b6a7f51a12ce0c97bfa28c084ed63"

combined-stream@^1.0.5, combined-stream@~1.0.5:
version "1.0.5"
resolved "https://registry.yarnpkg.com/combined-stream/-/combined-stream-1.0.5.tgz#938370a57b4a51dea2c77c15d5c5fdf895164009"
Expand Down Expand Up @@ -536,7 +578,7 @@ detect-newline@2.X:
version "2.1.0"
resolved "https://registry.yarnpkg.com/detect-newline/-/detect-newline-2.1.0.tgz#f41f1c10be4b00e87b5f13da680759f2c5bfd3e2"

diff@3.2.0:
diff@3.2.0, diff@^3.2.0:
version "3.2.0"
resolved "https://registry.yarnpkg.com/diff/-/diff-3.2.0.tgz#c9ce393a4b7cbd0b058a725c93df299027868ff9"

Expand Down Expand Up @@ -1162,7 +1204,7 @@ gulp-sourcemaps@^2.6.0:
through2 "2.X"
vinyl "1.X"

gulp-tslint@^8.0.0:
gulp-tslint@^8.1.1:
version "8.1.1"
resolved "https://registry.yarnpkg.com/gulp-tslint/-/gulp-tslint-8.1.1.tgz#1a906e59facaeacda900f3b412b0f46cfb0ab89f"
dependencies:
Expand Down Expand Up @@ -1529,6 +1571,10 @@ istanbul@^0.4.1:
which "^1.1.1"
wordwrap "^1.0.0"

js-tokens@^3.0.0:
version "3.0.2"
resolved "https://registry.yarnpkg.com/js-tokens/-/js-tokens-3.0.2.tgz#9866df395102130e38f7f996bceb65443209c25b"

js-yaml@3.6.1, js-yaml@3.x:
version "3.6.1"
resolved "https://registry.yarnpkg.com/js-yaml/-/js-yaml-3.6.1.tgz#6e5fe67d8b205ce4d22fad05b7781e8dadcc4b30"
Expand Down Expand Up @@ -1907,7 +1953,7 @@ mime@^1.2.11:
version "1.3.6"
resolved "https://registry.yarnpkg.com/mime/-/mime-1.3.6.tgz#591d84d3653a6b0b4a3b9df8de5aa8108e72e5e0"

"minimatch@2 || 3", minimatch@^3.0.2, minimatch@~3.0.2:
"minimatch@2 || 3", minimatch@^3.0.2, minimatch@^3.0.4, minimatch@~3.0.2:
version "3.0.4"
resolved "https://registry.yarnpkg.com/minimatch/-/minimatch-3.0.4.tgz#5166e286457f03306064be5497e8dbb0c3d32083"
dependencies:
Expand Down Expand Up @@ -2132,6 +2178,10 @@ path-is-inside@^1.0.1:
version "1.0.2"
resolved "https://registry.yarnpkg.com/path-is-inside/-/path-is-inside-1.0.2.tgz#365417dede44430d1c11af61027facf074bdfc53"

path-parse@^1.0.5:
version "1.0.5"
resolved "https://registry.yarnpkg.com/path-parse/-/path-parse-1.0.5.tgz#3c1adf871ea9cd6c9431b6ea2bd74a0ff055c4c1"

path-root-regex@^0.1.0:
version "0.1.2"
resolved "https://registry.yarnpkg.com/path-root-regex/-/path-root-regex-0.1.2.tgz#bfccdc8df5b12dc52c8b43ec38d18d72c04ba96d"
Expand Down Expand Up @@ -2389,6 +2439,12 @@ resolve@1.1.x, resolve@^1.1.6, resolve@^1.1.7, resolve@~1.1.7:
version "1.1.7"
resolved "https://registry.yarnpkg.com/resolve/-/resolve-1.1.7.tgz#203114d82ad2c5ed9e8e0411b3932875e889e97b"

resolve@^1.3.2:
version "1.3.3"
resolved "https://registry.yarnpkg.com/resolve/-/resolve-1.3.3.tgz#655907c3469a8680dc2de3a275a8fdd69691f0e5"
dependencies:
path-parse "^1.0.5"

retry-request@^1.3.2:
version "1.3.2"
resolved "https://registry.yarnpkg.com/retry-request/-/retry-request-1.3.2.tgz#59ad24e71f8ae3f312d5f7b4bcf467a5e5a57bd6"
Expand Down Expand Up @@ -2427,7 +2483,7 @@ semver@^4.1.0:
version "4.3.6"
resolved "https://registry.yarnpkg.com/semver/-/semver-4.3.6.tgz#300bc6e0e86374f7ba61068b5b1ecd57fc6532da"

semver@^5.1.0:
semver@^5.1.0, semver@^5.3.0:
version "5.3.0"
resolved "https://registry.yarnpkg.com/semver/-/semver-5.3.0.tgz#9b2ce5d3de02d17c6012ad326aa6b4d0cf54f94f"

Expand Down Expand Up @@ -2694,6 +2750,31 @@ tough-cookie@~2.3.0:
dependencies:
punycode "^1.4.1"

tslib@^1.7.1:
version "1.7.1"
resolved "https://registry.yarnpkg.com/tslib/-/tslib-1.7.1.tgz#bc8004164691923a79fe8378bbeb3da2017538ec"

tslint@^5.4.3:
version "5.5.0"
resolved "https://registry.yarnpkg.com/tslint/-/tslint-5.5.0.tgz#10e8dab3e3061fa61e9442e8cee3982acf20a6aa"
dependencies:
babel-code-frame "^6.22.0"
colors "^1.1.2"
commander "^2.9.0"
diff "^3.2.0"
glob "^7.1.1"
minimatch "^3.0.4"
resolve "^1.3.2"
semver "^5.3.0"
tslib "^1.7.1"
tsutils "^2.5.1"

tsutils@^2.5.1:
version "2.5.1"
resolved "https://registry.yarnpkg.com/tsutils/-/tsutils-2.5.1.tgz#c2001390c79eec1a5ccfa7ac12d599639683e0cf"
dependencies:
tslib "^1.7.1"

tunnel-agent@^0.6.0:
version "0.6.0"
resolved "https://registry.yarnpkg.com/tunnel-agent/-/tunnel-agent-0.6.0.tgz#27a5dea06b36b04a0a9966774b290868f0fc40fd"
Expand Down

0 comments on commit 2297c09

Please sign in to comment.