This repository has been archived by the owner on Apr 3, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 51
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
include variables from outer scopes (#271)
We were previously omitting variables from closure scopes. This can be problematic specifically in transpiled async functions as most actual variables end up in a closure.
- Loading branch information
Showing
5 changed files
with
170 additions
and
16 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,77 @@ | ||
// compile with | ||
// $ tsc --lib es6 --target es5 async.ts | ||
var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, generator) { | ||
return new (P || (P = Promise))(function (resolve, reject) { | ||
function fulfilled(value) { try { step(generator.next(value)); } catch (e) { reject(e); } } | ||
function rejected(value) { try { step(generator["throw"](value)); } catch (e) { reject(e); } } | ||
function step(result) { result.done ? resolve(result.value) : new P(function (resolve) { resolve(result.value); }).then(fulfilled, rejected); } | ||
step((generator = generator.apply(thisArg, _arguments || [])).next()); | ||
}); | ||
}; | ||
var __generator = (this && this.__generator) || function (thisArg, body) { | ||
var _ = { label: 0, sent: function() { if (t[0] & 1) throw t[1]; return t[1]; }, trys: [], ops: [] }, f, y, t, g; | ||
return g = { next: verb(0), "throw": verb(1), "return": verb(2) }, typeof Symbol === "function" && (g[Symbol.iterator] = function() { return this; }), g; | ||
function verb(n) { return function (v) { return step([n, v]); }; } | ||
function step(op) { | ||
if (f) throw new TypeError("Generator is already executing."); | ||
while (_) try { | ||
if (f = 1, y && (t = y[op[0] & 2 ? "return" : op[0] ? "throw" : "next"]) && !(t = t.call(y, op[1])).done) return t; | ||
if (y = 0, t) op = [0, t.value]; | ||
switch (op[0]) { | ||
case 0: case 1: t = op; break; | ||
case 4: _.label++; return { value: op[1], done: false }; | ||
case 5: _.label++; y = op[1]; op = [0]; continue; | ||
case 7: op = _.ops.pop(); _.trys.pop(); continue; | ||
default: | ||
if (!(t = _.trys, t = t.length > 0 && t[t.length - 1]) && (op[0] === 6 || op[0] === 2)) { _ = 0; continue; } | ||
if (op[0] === 3 && (!t || (op[1] > t[0] && op[1] < t[3]))) { _.label = op[1]; break; } | ||
if (op[0] === 6 && _.label < t[1]) { _.label = t[1]; t = op; break; } | ||
if (t && _.label < t[2]) { _.label = t[2]; _.ops.push(op); break; } | ||
if (t[2]) _.ops.pop(); | ||
_.trys.pop(); continue; | ||
} | ||
op = body.call(thisArg, _); | ||
} catch (e) { op = [6, e]; y = 0; } finally { f = t = 0; } | ||
if (op[0] & 5) throw op[1]; return { value: op[0] ? op[1] : void 0, done: true }; | ||
} | ||
}; | ||
function delay(t) { | ||
return new Promise(function (resolve, reject) { | ||
setTimeout(resolve, t); | ||
}); | ||
} | ||
function get(path, handler) { | ||
var _this = this; | ||
delay(10).then(function () { | ||
var req = { | ||
name: 'fake request', | ||
path: path | ||
}; | ||
var res = { | ||
name: 'fake response', | ||
status: function (statusCode) { | ||
_this.statusCode = statusCode; | ||
return _this; | ||
}, | ||
send: function (msg) { | ||
console.log(msg); | ||
} | ||
}; | ||
handler(req, res); | ||
}); | ||
} | ||
function run() { | ||
var _this = this; | ||
get('/foo', function (req, res) { return __awaiter(_this, void 0, void 0, function () { | ||
return __generator(this, function (_a) { | ||
switch (_a.label) { | ||
case 0: return [4 /*yield*/, delay(10)]; | ||
case 1: | ||
_a.sent(); | ||
res.status(200); | ||
return [2 /*return*/]; | ||
} | ||
}); | ||
}); }); | ||
} | ||
module.exports = run; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
// compile with | ||
// $ tsc --lib es6 --target es5 async.ts | ||
|
||
function delay(t) { | ||
return new Promise((resolve, reject) => { | ||
setTimeout(resolve, t); | ||
}); | ||
} | ||
|
||
function get(path, handler) { | ||
delay(10).then(() => { | ||
const req = { | ||
name: 'fake request', | ||
path: path | ||
}; | ||
const res = { | ||
name: 'fake response', | ||
status: (statusCode) => { | ||
this.statusCode = statusCode; | ||
return this; | ||
}, | ||
send: (msg) => { | ||
console.log(msg); | ||
} | ||
} | ||
handler(req, res); | ||
}); | ||
} | ||
|
||
function run() { | ||
get('/foo', async (req, res) => { | ||
await delay(10); | ||
res.status(200); | ||
}); | ||
} | ||
|
||
module.exports = run; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters