Skip to content
This repository has been archived by the owner on Apr 3, 2024. It is now read-only.

Commit

Permalink
fix: Skip 32bit platform warning starting on 8.9 (#351)
Browse files Browse the repository at this point in the history
As asnyc stack traces will not be turned on by default statring with node
8.9.0, The warning message of 'async stack trace is not available on 32 bit
platform' no longer emitted. We will not emit this elaboration to users.
  • Loading branch information
gaofanmichael committed Nov 2, 2017
1 parent 185f1c2 commit e108967
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion test/test-debuglet.ts
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,8 @@ describe('Debuglet', function() {
// TODO: Handle the case where debuglet.debuggee is undefined
assert.equal((debuglet.debuggee_ as Debuggee).project, projectId);
const arch = process.arch;
if (semver.satisfies(process.version, '>=8.5') &&
if (semver.satisfies(process.version, '>=8.5.0') &&
semver.satisfies(process.version, '<8.9.0') &&
(arch === 'ia32' || arch === 'x86') &&
process.env.GCLOUD_USE_INSPECTOR) {
assert(logText.includes(utils.messages.ASYNC_TRACES_WARNING));
Expand Down

0 comments on commit e108967

Please sign in to comment.