Skip to content
This repository has been archived by the owner on Apr 3, 2024. It is now read-only.

Commit

Permalink
Address a formating error across Node versions (#328)
Browse files Browse the repository at this point in the history
  • Loading branch information
DominicKramer committed Sep 9, 2017
1 parent 17be882 commit fa36973
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 10 deletions.
6 changes: 3 additions & 3 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"@types/semver": "^5.3.32",
"@types/source-map": "^0.5.0",
"changelog-maker": "^2.2.2",
"clang-format": "^1.0.53",
"clang-format": "^1.0.55",
"closure-npc": "*",
"coveralls": "^2.11.2",
"del": "^2.2.2",
Expand Down
2 changes: 1 addition & 1 deletion src/agent/state.ts
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ const ARG_LOCAL_LIMIT_MESSAGE_INDEX = 3;
* @return an object with error and mirror fields.
*/
export function evaluate(expression: string, frame: v8Types.FrameMirror):
{error: string | null, mirror?: v8Types.ValueMirror} {
{error: string|null, mirror?: v8Types.ValueMirror} {
// First validate the expression to make sure it doesn't mutate state
const acorn = require('acorn');
try {
Expand Down
4 changes: 2 additions & 2 deletions src/agent/v8debugapi.ts
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,8 @@ export function create(
// Entries map breakpoint id to { enabled: <bool>, listener: <function> }
// TODO: Determine if the listener type is correct
const listeners:
{[id: string]:
{enabled: boolean; listener: (...args: any[]) => any;}} = {};
{[id: string]: {enabled: boolean;
listener: (...args: any[]) => any;}} = {};
let numBreakpoints = 0;
// Before V8 4.5, having a debug listener active disables optimization. To
// deal with this we only activate the listener when there is a breakpoint
Expand Down
5 changes: 2 additions & 3 deletions test/auth-request.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,10 @@
'use strict';

import * as request from 'request';
import * as http from 'http';

// TODO: Make the type of `options` more precise
export default function(options: any, callback: (err: Error, body: any, response: http.ServerResponse) => void) {
request(options, function(err: Error, response: http.ServerResponse, body: any) {
export default function(options: any, callback: (err: Error, body: any, response: request.RequestResponse) => void) {
request(options, function(err: Error, response: request.RequestResponse, body: any) {
callback(err, body, response);
});
};

0 comments on commit fa36973

Please sign in to comment.