Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add build/src/cls in output files #736

Merged
merged 1 commit into from May 2, 2018
Merged

Conversation

kjin
Copy link
Contributor

@kjin kjin commented May 2, 2018

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 2, 2018
Copy link
Contributor

@ofrobots ofrobots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as this fixes a bogus release.

Looking over the list, it is not clear to me why the list of cherry-picked .d.ts files is sufficient. At any point a new file may be added that these files depend upon. I would like to see a more 'obviously correct' solution the problem of what types get shipped, e.g. a wildcard pattern for types.

@kjin kjin merged commit 49a900a into googleapis:master May 2, 2018
@kjin
Copy link
Contributor Author

kjin commented May 2, 2018

@ofrobots It's the list of "reachable" d.ts definitions from index.d.ts. This is being detected by the install test which is run on each PR, since it type-checks (and only type-checks, not runs) the statement import * as trace from '@google-cloud/trace-agent'. What we could do to avoid the much more important problem of ensuring that the correct .js files are included is to actually run the code in the install test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants