Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add log level to logger prefix #875

Merged
merged 1 commit into from Oct 1, 2018
Merged

fix: add log level to logger prefix #875

merged 1 commit into from Oct 1, 2018

Conversation

kjin
Copy link
Contributor

@kjin kjin commented Sep 28, 2018

The new Logger class doesn't include ERROR/WARN etc to allow users to distinguish log levels... this PR fixes this.

@kjin kjin requested a review from a team September 28, 2018 21:13
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 28, 2018
@ghost ghost assigned kjin Sep 28, 2018
@soldair soldair self-requested a review October 1, 2018 16:40
soldair
soldair approved these changes Oct 1, 2018
View reviewed changes
Copy link
Contributor

@soldair soldair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@kjin kjin merged commit c19850d into googleapis:master Oct 1, 2018
@release-please release-please bot mentioned this pull request Jun 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soldair soldair soldair approved these changes

Assignees

@kjin kjin

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kjin @soldair @googlebot