feat: introduce CommitSigner interface #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chingor13
force-pushed
the
commit-signer
branch
from
77625f8
to
95e74ea
Compare
bcoe
approved these changes
Jan 25, 2023
| @@ -44,6 +60,9 @@ export async function createCommit( | |||
| message, | |||
| tree: treeSha, | |||
| parents: [refHead], | |||
| signature, | |||
There was a problem hiding this comment.
If you can find the REST documentation in the GitHub API, adding it here as a comment would be useful.
I'm interested to know what options we have available to us for a signing algorithm (I'm hoping we might be able to use something other than GPG).
There was a problem hiding this comment.
Added a link to the create commit API docs. It looks like only PGP is supported for this API
This was referenced Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #337
This introduces an interface to allow providing a commit signer, but does not include any implementation.