Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support google-protobuf >= 4.26 in gemspec #267

Closed
qnighy opened this issue Mar 28, 2024 · 2 comments · Fixed by #315
Closed

Support google-protobuf >= 4.26 in gemspec #267

qnighy opened this issue Mar 28, 2024 · 2 comments · Fixed by #315
Assignees
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@qnighy
Copy link

qnighy commented Mar 28, 2024

Problem

protobuf v26.0 had been released, and it contains breaking changes to the Ruby runtime. This resulted in the gem being bumped from 3.25 to 4.26.

However, as googleapis-common-protos-types and grpc restricts the google-protobuf version within 3.x, the new version is virtually unavailable as of now.

Expected solution

The version restriction is relaxed from "~> 3.18" to ">= 3.18", "< 5.0". Additionally, incompatibilities are fixed if any. Note that the biggest change (to my understanding) is the Ruby DSL removal and it is already resolved in #165.

@qnighy qnighy added priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Mar 28, 2024
@dazuma
Copy link
Member

dazuma commented Mar 28, 2024

Thanks @qnighy! Yes, we will get a relaxed version restriction through the rest of the api clients stack once we've been able to verify compatibility.

@colinbendell
Copy link

What is the expected eta of supporting the 4.x series?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants