tests: Reverse position on explicit "must exist" for update

googleapis · Jan 18, 2024 · 3de4678 · 3de4678
1 parent 3264aa6
commit 3de4678
Show file tree

Hide file tree

Showing 2 changed files with 50 additions and 6 deletions.
diff --git a/firestore/v1/update-exists-precond.json b/firestore/v1/update-exists-precond.json
@@ -1,15 +1,37 @@
 {
   "tests": [
     {
-      "description": "update: Exists precondition is invalid",
-      "comment": "The Update method does not support an explicit exists precondition.",
+      "description": "update: Exists precondition is valid",
+      "comment": "The Update method supports an explicit exists precondition.",
       "update": {
         "docRefPath": "projects/projectID/databases/(default)/documents/C/d",
         "precondition": {
           "exists": true
         },
         "jsonData": "{\"a\": 1}",
-        "isError": true
+        "request": {
+          "database": "projects/projectID/databases/(default)",
+          "writes": [
+            {
+              "update": {
+                "name": "projects/projectID/databases/(default)/documents/C/d",
+                "fields": {
+                  "a": {
+                    "integerValue": "1"
+                  }
+                }
+              },
+              "updateMask": {
+                "fieldPaths": [
+                  "a"
+                ]
+              },
+              "currentDocument": {
+                "exists": true
+              }
+            }
+          ]
+        }
       }
     }
   ]

diff --git a/firestore/v1/update-paths-exists-precond.json b/firestore/v1/update-paths-exists-precond.json
@@ -1,8 +1,8 @@
 {
   "tests": [
     {
-      "description": "update-paths: Exists precondition is invalid",
-      "comment": "The Update method does not support an explicit exists precondition.",
+      "description": "update-paths: Exists precondition is valid",
+      "comment": "The Update method supports an explicit exists precondition.",
       "updatePaths": {
         "docRefPath": "projects/projectID/databases/(default)/documents/C/d",
         "precondition": {
@@ -18,7 +18,29 @@
         "jsonValues": [
           "1"
         ],
-        "isError": true
+        "request": {
+          "database": "projects/projectID/databases/(default)",
+          "writes": [
+            {
+              "update": {
+                "name": "projects/projectID/databases/(default)/documents/C/d",
+                "fields": {
+                  "a": {
+                    "integerValue": "1"
+                  }
+                }
+              },
+              "updateMask": {
+                "fieldPaths": [
+                  "a"
+                ]
+              },
+              "currentDocument": {
+                "exists": true
+              }
+            }
+          ]
+        }
       }
     }
   ]