Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate Docker command not running properly #457

Closed
dandhlee opened this issue May 10, 2023 · 0 comments · Fixed by #605
Closed

Investigate Docker command not running properly #457

dandhlee opened this issue May 10, 2023 · 0 comments · Fixed by #605
Assignees
@tbpg
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@dandhlee
Copy link
Contributor

When the docker command was run with UPDATE_GOLDENS=1, there was a report that it did not work as intended and a few tweak to the existing CI scripts had to be made.
@dandhlee dandhlee added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels May 10, 2023
@dandhlee dandhlee self-assigned this May 10, 2023
@tbpg tbpg assigned tbpg and unassigned dandhlee Jan 11, 2024
@tbpg tbpg mentioned this issue Jan 11, 2024
Merged
@tbpg tbpg closed this as completed in #605 Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tbpg tbpg

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: configure Trampoline to forward UPDATE_GOLDENS environment variable googleapis/doc-pipeline
2 participants
@tbpg @dandhlee