Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize parameter order #57

Closed
chingor13 opened this issue Feb 20, 2018 · 0 comments
Closed

Standardize parameter order #57

chingor13 opened this issue Feb 20, 2018 · 0 comments
Assignees
@chingor13
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. 🚨 This issue needs some love. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@chingor13
Copy link
Contributor

When rebuilding APIs, sometimes the (optional) parameters ordering changes. This adds unnecessary noise when reviewing changes.

This is due to the fact that swagger-codegen and the api spec converter do not sort the parameters. The discovery endpoints can return discovery docs with differing ordering.
@chingor13 chingor13 mentioned this issue Feb 20, 2018
Merged
@dazuma dazuma added the priority: p2 Moderately-important priority. Fix may not be included in next release. label May 11, 2018
@chingor13 chingor13 added the type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. label Jul 2, 2018
@JustinBeckwith JustinBeckwith added the 🚨 This issue needs some love. label Sep 20, 2018
@chingor13 chingor13 mentioned this issue Nov 16, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chingor13 chingor13

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. 🚨 This issue needs some love. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dazuma @chingor13 @JustinBeckwith