feat: Add Maven release #1111
Merged
feat: Add Maven release #1111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lqiu96
reviewed
Dec 5, 2022
lqiu96
reviewed
Dec 5, 2022
| # Configure the docker image for kokoro-trampoline. | ||
| env_vars: { | ||
| key: "TRAMPOLINE_IMAGE" | ||
| value: "gcr.io/cloud-devrel-kokoro-resources/java8" |
There was a problem hiding this comment.
I know we had internal discussions about java8 vs java11 for this image. No preference from my end in this PR, but this is something to keep in mind in the gapic monorepo.
There was a problem hiding this comment.
Unlike the other repos where we can compile with Java 11 and make the source compatible with Java 8, we have to compile gapic-generator-java in Java 8. It's not a dependency to client libraries, it has to load classes from Java 8 instead of Java 11 during compilation time.
blakeli0
commented
Dec 9, 2022
burkedavison
approved these changes
Dec 9, 2022
suztomo
reviewed
Dec 9, 2022
suztomo
reviewed
Dec 9, 2022
suztomo
reviewed
Dec 9, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.kokorofolder for releasing gapic-generaotr-java as a jar..kokorofolder in gax-java, and only keeping the necessary.simpletojava-yoshi