feat: parent pom and gapic-generator-java-bom #1170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
suztomo
commented
Dec 20, 2022
•
suztomo
commented
- gapic-generator-java-pom-parent: the parent pom of all modules.
- gapic-generator-java-bom: the BOM for the artifacts produced by this repository.
- modules in gax-java and api-common to have SNAPSHOT versions.
suztomo
commented
Dec 20, 2022
| gax:2.20.1:2.20.1 | ||
| gax-bom:2.20.1:2.20.1 |
There was a problem hiding this comment.
I've replaced gax-bom's occurrences with gax in Release Please annotations.
ddixit14
approved these changes
Dec 20, 2022
suztomo
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
suztomo
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
suztomo
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
suztomo
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
suztomo
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
|
Kudos, SonarCloud Quality Gate passed!
|
suztomo
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
suztomo
commented
Dec 21, 2022
Comment on lines
+104
to
+105
| run: mvn -B -ntp --projects '!.' fmt:check |
There was a problem hiding this comment.
With this PR, gapic-generator-java alone does not work. So running the fmt:check plugin from the root.
suztomo
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.